Skip to content

BUG: assert_frame_equal raising TypeError with check_like and mixed dtype in Index or columns #39204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 16, 2021
Merged

BUG: assert_frame_equal raising TypeError with check_like and mixed dtype in Index or columns #39204

merged 3 commits into from
Jan 16, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 16, 2021

Worked on 1.1.5 for assert_frame_equal and was not supported for assert_index_equal

@phofl phofl added Regression Functionality that used to work in a prior pandas version Testing pandas testing functions or related to the test suite labels Jan 16, 2021
@jreback jreback added this to the 1.2.1 milestone Jan 16, 2021
jreback
jreback approved these changes Jan 16, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ping on greenish

@phofl
Copy link
Member Author

phofl commented Jan 16, 2021

@jreback green

@jreback jreback merged commit c5b4272 into pandas-dev:master Jan 16, 2021
@jreback
Copy link
Contributor

jreback commented Jan 16, 2021

thanks @phofl

@jreback
Copy link
Contributor

jreback commented Jan 16, 2021

@meeseeksdev backport 1.2.x

@lumberbot-app

This comment has been minimized.

Sign in to view
simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Jan 16, 2021
@phofl @simonjayhawkins
Backport PR pandas-dev#39204: BUG: assert_frame_equal raising TypeErr…
973784a 
…or with check_like and mixed dtype in Index or columns
@simonjayhawkins simonjayhawkins mentioned this pull request Jan 16, 2021
Merged
@phofl phofl deleted the 39168 branch January 16, 2021 14:59
jreback pushed a commit that referenced this pull request Jan 16, 2021
@simonjayhawkins
Backport PR #39204: BUG: assert_frame_equal raising TypeError with ch…
9b47cb9 
…eck_like and mixed dtype in Index or columns (#39208)
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@phofl @luckyvs1
BUG: assert_frame_equal raising TypeError with check_like and mixed …
78e3968 
…dtype in Index or columns (pandas-dev#39204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Regression Functionality that used to work in a prior pandas version Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

BUG: assert_frame_equal() with check_like=True errors with non-comparable types
3 participants
@phofl @jreback @simonjayhawkins